Re: [PATCH v2] staging: fbtft: Fix line length warning
From: Andy Shevchenko
Date: Sun Oct 25 2026 - 17:02:31 EST
On Sun, Oct 25, 2026 at 10:10:03PM +0530, himanshu bakshi wrote:
> From: Himanshu Bakshi <himanshu.bakshi478@xxxxxxxxx>
>
> Hi Andy,
>
> I have made sure that the \ (backslash) is properly aligned to the same
> column as the rest of the macro. I have also taken into account your
> advice and hence added a local variable for platform data.
>
> After some thorough searching through the respective directory, I have
> not found any calls for fbtft_init_dbg. This might be because it's a
> helper macro that might be useful as the driver progresses.
>
> I have also noticed that some other macros around this one have simple
> style issues and if you would like, I can send another different patch
> cleaning up those too.
>
> I have also done minimal testing by using the macro once to make sure it
> compiles and has no errors, if you would like, I can also run any
> standalone tests for this macro.
>
> Thanks and Regards,
> Himanshu Bakshi
It's not a commit message. Please, make commit message be appropriate and
any comments like above is better to be sent in the reply of the previous
discussion (v1 round in this case, for instance).
> Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@xxxxxxxxx>
> ---
--
With Best Regards,
Andy Shevchenko