Re: [PATCH] staging: rtl8723bs: remove unnecessary goto

[Julia Lawall]

On Sun, 25 Oct 2026, Haasham Khan wrote:

> The goto exit statement jumps to the next statement, so it has no
> effect. Remove it and the now-unnecessary label, and simplify the
> conditional block.
>
> Signed-off-by: Haasham Khan <haasham93@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Actually, this driver isn't accepting patches any more, because it will be
removed.  This was discussed on the mailing list recently.

julia

>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 6f4bdad00f60..c2d0cd314b81 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -2005,12 +2005,9 @@ static int recv_func_prehandle(struct adapter *padapter, union recv_frame *rfram
>
>  	/* check the frame crtl field and decache */
>  	ret = validate_recv_frame(padapter, rframe);
> -	if (ret != _SUCCESS) {
> +	if (ret != _SUCCESS)
>  		rtw_free_recvframe(rframe, pfree_recv_queue);/* free this recv_frame */
> -		goto exit;
> -	}
>
> -exit:
>  	return ret;
>  }
>
> --
> 2.53.0
>
>
>