Re: [PATCH 0/5] Add support for a TEE agnostic Inline Crypto Engine service

[Eric Biggers]

On Wed, Oct 21, 2026 at 09:13:06PM +0530, Harshal Dev wrote:
> This patch series adds a generic ICE service which provides TEE agnostic
> APIs

There is already an ICE driver: drivers/soc/qcom/ice.c.  If it needs to
do different things on different platforms, then it should be updated to
do so.  Adding a separate middleware module underneath it, with the ICE
driver as its sole user, is unnecessary complexity that will just cause
problems.

In fact the middleware module is called qcom_ice.ko, which is the exact
same name as the ICE driver.  That's broken, as it's a name collision.
I think the fact they have the same name hints pretty strongly that the
functionality should just be incorporated into the existing qcom_ice.ko.

AFAICT, this series also breaks boot on platforms without ICE firmware
support, due to indefinite EPROBE_DEFER.  Choosing a simpler design
would help avoid issues like that.

- Eric