[PATCH v5 0/4] E5010 Probe Cleanup and Adding autosuspend
From: b-brnich
Date: Thu Oct 22 2026 - 15:15:50 EST
From: Brandon Brnich <b-brnich@xxxxxx>
Hello all,
I noticed a report from the intel bot[0] which pointed out a valid issue
with the driver never calling e5010_init_device unless CONFIG_PM was
enabled.
While looking at probe though, I noticed that the clk_enable was never
properly called. That has now been fixed with a proper remove path as
well.
Lastly, I cleaned up the goto jumps in probe to fix an issue where the
m2m_dev wasn't being freed.
Changes since v4:
- Change authorship of patch 1 since Myeonghun sent a similar patch
first
- addressed Devarsh's comments in Patch 1 to follow similar naming
structure as rest of probe function
- Moved the clk_enable call after pm_runtime_enable here so I can check
success of that call. If runtime pm is enabled then don't enable the
clock here
- Patch 3 no changes
- Patch 4 I added the macro requested by Devarsh instead of using magic
number
- failure to power on now goes through the existing no_ready_buf_err path,
so buffers are marked as error and the job is finished
Changes since v3:
- patches 1 and 2 are new in v4
- patch 3 remains unchanged
- patch 4
> updated goto to match changes in patch 1
> update PM calls in probe
Best,
Brandon
[0]: https://lore.kernel.org/oe-kbuild-all/202608140323.qyc8mKlp-lkp@xxxxxxxxx/
Brandon Brnich (3):
media: imagination: e5010: Fix clk never enabled without CONFIG_PM
media: imagination: e5010: Move e5010_init_device to Runtime Resume
Hook
media: imagination: e5010: Enable autosuspend for runtime PM
Myeonghun Pak (1):
media: imagination: e5010: release m2m device on probe failure
.../platform/imagination/e5010-jpeg-enc.c | 86 +++++++++++--------
.../platform/imagination/e5010-jpeg-enc.h | 1 +
2 files changed, 52 insertions(+), 35 deletions(-)
--
2.43.0