Re: [PATCH v11 3/3] arm64: dts: rockchip: rk3568-photonicat: enable SGMII LAN port

[David Heidelberg]

On 22/10/2026 18:58, Andrew Lunn wrote:
> > +	sgmii_phy: ethernet-phy@3 {
> > +		compatible = "ethernet-phy-ieee802.3-c22";
> > +		reg = <0x3>;
> > +		max-speed = <1000>;
>
> Pointless. SGMII cannot do faster, so there is no need to limit it.

device-tree is a description. whatever the device can do should be there,

"Maximum PHY supported speed in Mbits / seconds." thus 1000 is correct value.

thus max-speed <1000>; LGTM

David

> 	Andrew