Re: [PATCH v3 2/4] media: wave5: use m2m buffer completion helper
From: Brandon Brnich
Date: Thu Oct 22 2026 - 11:55:59 EST
Hi Jiale,
Thanks for the patch.
On 10/21/26 10:15, Jiale Yao wrote:
The decoder destination queue handles a runtime resume failure by
completing the queued buffer. The driver is a mem2mem driver, so use
v4l2_m2m_buf_done() to preserve mem2mem queue bookkeeping instead of
calling vb2_buffer_done() directly.
You can add fixes here. 158b39a0f7d198 is the commit-sha
Tested-by: Brandon Brnich <b-brnich@xxxxxx>
Signed-off-by: Jiale Yao <yaojiale02@xxxxxxx>
---
drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
index 320b40581b..467c68931e 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
@@ -1309,7 +1309,7 @@ static void wave5_vpu_dec_buf_queue_dst(struct vb2_buffer *vb)
ret = pm_runtime_resume_and_get(inst->dev->dev);
if (ret < 0) {
- vb2_buffer_done(vb, VB2_BUF_STATE_ERROR);
+ v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR);
return;
}