RE: [PATCH v3 3/6] iio: imu: Add driver for the ADI ADIS16607
From: Sabau, Radu bogdan
Date: Thu Oct 22 2026 - 06:26:28 EST
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Sent: Thursday, October 15, 2026 10:05 PM
...
> > + /* Route a reset-status indicator to its own pin, if reset-gpios is wired
> */
> > + if (device_property_present(dev, "reset-gpios")) {
>
> Huh?! Can we use reset framework instead and do something with help of it?
>
> > + ret = __adis_update_bits_base(adis,
> ADIS16607_REG_USER_GPIO_CFG,
> > + ADIS16607_RESET_GPIO_MASK,
> > +
> FIELD_PREP(ADIS16607_RESET_GPIO_MASK, 1), 2);
> > + if (ret)
> > + return ret;
> > + }
>
Hi Andy, thank you also for taking a look.
This code will be removed from here to probe() as per the possibility of
the device hanging discussion, it make much more sense for it to be there.
This was writing RESET_GPIO_MASK after reset, which pretty much was a
no-op since the device already defaults with that bit set.
Removed the duplicate here entirely - it's not reset-line handling
or reset-framework territory, just an on-chip pin-function register,
and now it will only exist in the one place where it matters.
Thanks,
Radu