Re: [PATCH net] selftests: gro: remove unused variable total_data

[Antoine Tenart]

On Thu, Oct 22, 2026 at 11:09:35AM +0800, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@xxxxxxxxxx>
> 
> I hit a build warning when building the net selftests.
> 
>   gro.c: In function 'check_capacity_pkts':                                                                                                                                                                                     gro.c:1249:13: warning: variable 'total_data' set but not used [-Wunused-but-set-variable=]
>    1249 |         int total_data = 0;
>         |             ^~~~~~~~~~
> 
> Remove the total_data variable, as it is no longer used.
> 
> Fixes: d97348474708 ("selftests: drv-net: gro: always wait for FIN in the capacity test")
> Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxxx>

Reviewed-by: Antoine Tenart <atenart@xxxxxxxxxx>

> ---
>  tools/testing/selftests/net/lib/gro.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/lib/gro.c b/tools/testing/selftests/net/lib/gro.c
> index 7a333155de1a..1bc92e7a625f 100644
> --- a/tools/testing/selftests/net/lib/gro.c
> +++ b/tools/testing/selftests/net/lib/gro.c
> @@ -1246,7 +1246,6 @@ static void check_capacity_pkts(int fd)
>  	int coalesced[num_flows];
>  	struct tcphdr *tcph;
>  	int ip_ext_len = 0;
> -	int total_data = 0;
>  	int pkt_size = -1;
>  	int data_len = 0;
>  	int flow_id;
> @@ -1309,7 +1308,6 @@ static void check_capacity_pkts(int fd)
>  		}
>  
>  		num_pkt++;
> -		total_data += data_len;
>  	}
>  
>  	/* Check flow ordering. We expect to see all non-coalesced first segs
> 
> ---
> base-commit: e0a958ddfc89f2e1c43448cdaeb5b30e54e19448
> change-id: 20261022-self_unused_var-d54af8d61a56
> 
> Best regards,
> --  
> Hangbin Liu <liuhangbin@xxxxxxxxxx>
>