Re: [RFC PATCH v2 06/11] iommufd: Map memory provider files

[Samiullah Khawaja]

On Wed, Oct 14, 2026 at 09:37:28AM +0000, Fred Griffoul wrote:
> From: Fred Griffoul <fgriffo@xxxxxxxxxxxx>
>
> IOMMU_IOAS_MAP_FILE pins the pages it maps, which cannot work for a
> memory provider file: the frames may have no struct page, and the
> provider can take any of them back at any time.
>
> Accept a provider file. iommufd neither pins nor accounts its pages.
> It asks the provider for each frame when it fills a domain, and on a
> revoke it unmaps the range in every domain and maps what the provider
> backs now. A device that accesses the range in between faults. A
> revoke charges the page tables it allocates to the memory cgroup that
> mapped the file, not to the task that revoked.
>
> Each frame gets a PAGE_SIZE entry, so a partial revoke never splits a
> large IOMMU page. The next patch maps larger blocks. Holes stay
> unmapped, read-only pages are mapped without IOMMU_WRITE, and MMIO
> pages with IOMMU_MMIO. Frame 0 is refused with -EINVAL: iova_to_phys()
> returns 0 for an IOVA that is not mapped, so a revoke would take that
> page for a hole and leave it mapped.
>
> A revoke would race a dirty bitmap read and lose the dirty bits of the
> range, so provider pages and a dirty tracking domain cannot share an
> IOAS: whichever comes second fails with -EOPNOTSUPP. A provider
> mapping cannot be split by a partial unmap, and in-kernel accesses to
> it are refused.
>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Fred Griffoul <fgriffo@xxxxxxxxxxxx>
> ---
> drivers/iommu/iommufd/Kconfig        |   1 +
> drivers/iommu/iommufd/io_pagetable.c |  13 +-
> drivers/iommu/iommufd/io_pagetable.h |  27 ++-
> drivers/iommu/iommufd/pages.c        | 288 ++++++++++++++++++++++++++-
> include/uapi/linux/iommufd.h         |  11 +-
> 5 files changed, 334 insertions(+), 6 deletions(-)

[snip]

> +
> /* The pages are not pinned, so their domains are tracked in pages->tracker. */
> static inline bool iopt_pages_tracked(struct iopt_pages *pages)
> {
> -	return iopt_is_dmabuf(pages);
> +	return iopt_is_dmabuf(pages) || iopt_is_provider(pages);
> }
>
> static inline bool iopt_dmabuf_revoked(struct iopt_pages *pages)
> @@ -285,6 +306,10 @@ struct iopt_pages *iopt_alloc_dmabuf_pages(struct iommufd_ctx *ictx,
> 					   unsigned long start_byte,
> 					   unsigned long start,
> 					   unsigned long length, bool writable);
> +struct iopt_pages *iopt_alloc_provider_pages(struct file *file,
> +					     unsigned long start,
> +					     unsigned long length,
> +					     bool writable);
> void iopt_release_pages(struct kref *kref);
> static inline void iopt_put_pages(struct iopt_pages *pages)
> {
> diff --git a/drivers/iommu/iommufd/pages.c b/drivers/iommu/iommufd/pages.c
> index 660af3d46f5e..aa7740326ad6 100644
> --- a/drivers/iommu/iommufd/pages.c
> +++ b/drivers/iommu/iommufd/pages.c
> @@ -52,6 +52,8 @@
> #include <linux/iommu.h>
> #include <linux/iommufd.h>
> #include <linux/kthread.h>
> +#include <linux/mem_provider.h>
> +#include <linux/memcontrol.h>
> #include <linux/overflow.h>
> #include <linux/slab.h>
> #include <linux/sched/mm.h>
> @@ -238,6 +240,35 @@ static void iommu_unmap_nofail(struct iommu_domain *domain, unsigned long iova,
> 	WARN_ON(ret != size);
> }
>
> +/*
> + * Provider pages are mapped with PAGE_SIZE entries, and may have holes.  Some
> + * IOMMU drivers warn when asked to unmap an IOVA that is not mapped, so find
> + * the runs that are mapped and unmap each one, without touching the holes.
> + * iopt_provider_map() refuses frame 0, which iova_to_phys() reports for
> + * an IOVA that is not mapped.
> + */
> +static void iopt_provider_unmap(struct iopt_area *area,
> +				struct iommu_domain *domain,
> +				unsigned long start_index,
> +				unsigned long last_index)
> +{
> +	unsigned long iova = iopt_area_index_to_iova(area, start_index);
> +	size_t left = (last_index - start_index + 1) * PAGE_SIZE;
> +
> +	while (left) {
> +		size_t len = 0;
> +
> +		while (len < left && iommu_iova_to_phys(domain, iova + len))
> +			len += PAGE_SIZE;
> +		if (len)
> +			iommu_unmap_nofail(domain, iova, len);
> +		/* Step over the run and the hole page that ended it. */
> +		len = min(len + PAGE_SIZE, left);
> +		iova += len;
> +		left -= len;
> +	}
> +}
> +
> static void iopt_area_unmap_domain_range(struct iopt_area *area,
> 					 struct iommu_domain *domain,
> 					 unsigned long start_index,
> @@ -245,6 +276,11 @@ static void iopt_area_unmap_domain_range(struct iopt_area *area,
> {
> 	unsigned long start_iova = iopt_area_index_to_iova(area, start_index);
>
> +	if (area->provider) {
> +		iopt_provider_unmap(area, domain, start_index, last_index);
> +		return;
> +	}
> +
> 	iommu_unmap_nofail(domain, start_iova,
> 			   iopt_area_index_to_iova_last(area, last_index) -
> 				   start_iova + 1);
> @@ -1349,6 +1385,10 @@ static int pfn_reader_first(struct pfn_reader *pfns, struct iopt_pages *pages,
> 	    WARN_ON(last_index < start_index))
> 		return -EINVAL;
>
> +	/* Provider pages are read from the provider, see iopt_provider_map() */
> +	if (WARN_ON(iopt_is_provider(pages)))
> +		return -EINVAL;
> +
> 	rc = pfn_reader_init(pfns, pages, start_index, last_index);
> 	if (rc)
> 		return rc;
> @@ -1647,6 +1687,228 @@ void iopt_pages_untrack_all_domains(struct iopt_area *area,
> 	}
> }
>
> +static int iopt_provider_prot(struct iopt_area *area, u32 attrs)
> +{
> +	int prot = area->iommu_prot;
> +
> +	if (attrs & MEM_PROVIDER_ATTR_READONLY)
> +		prot &= ~IOMMU_WRITE;
> +	if (mem_provider_type(attrs) != MEM_PROVIDER_TYPE_RAM) {
> +		prot &= ~IOMMU_CACHE;
> +		prot |= IOMMU_MMIO;
> +	}
> +	return prot;
> +}
> +
> +/*
> + * Map what the provider backs in [start_index, last_index] of the area into
> + * @domain, and leave the holes unmapped.  Each frame is mapped with a
> + * PAGE_SIZE entry, so that a revoke of part of a large block never has to
> + * split a larger IOMMU page.  On failure nothing in the range is mapped.
> + */
> +static int iopt_provider_map(struct iopt_area *area, struct iopt_pages *pages,
> +			     struct iommu_domain *domain,
> +			     unsigned long start_index,
> +			     unsigned long last_index)
> +{
> +	unsigned long base = pages->provider.start >> PAGE_SHIFT;
> +	unsigned long index = start_index;
> +	int rc;
> +
> +	lockdep_assert_held(&pages->mutex);
> +
> +	if ((1UL << __ffs(domain->pgsize_bitmap)) > PAGE_SIZE)
> +		return -EOPNOTSUPP;
> +
> +	/*
> +	 * A revoke unmaps under pages->mutex only, so it would race with a
> +	 * dirty bitmap read, and lose the dirty bits of what it unmaps.
> +	 * Provider pages are not mapped in a domain with dirty tracking.
> +	 */
> +	if (domain->dirty_ops)
> +		return -EOPNOTSUPP;
> +
> +	while (index <= last_index) {
> +		unsigned long pfn, iova, block_end, nr, i;
> +		int order = PUD_ORDER;
> +		u32 attrs;
> +		int prot;
> +
> +		rc = mem_provider_get_page(&pages->provider.att, base + index,
> +					   &pfn, &order, &attrs);
> +		if (rc == -EFAULT) {
> +			index++;
> +			continue;

Hi Fred,

Thanks for this.

With this approach, silently skipping holes during IOAS_MAP_FILE means
iommufd has no tracking of which IOVA ranges in the area are actually
mapped, which complicates unmap and could also hide a bug if a hole in
the range was not expected?

I am wondering whether the areas can track the holes, or whether we
should have areas for the mapped/unmapped ranges? This should allow
proper sanity checks when doing revoke. I am also thinking about this
from the live update point of view, where we might need to sanity check
that the backing memory of mapped regions is preserved.

Could you please CC me on v3? I'd like to follow this from the live
update IOMMU and iommufd preservation side.

https://lore.kernel.org/all/20260921004834.2601285-1-skhawaja@xxxxxxxxxx/

Thanks,
Sami