Re: [PATCH rtw-next v4] wifi: rtw88: pci: wake the TX queues after restart_hw and interface up

[Luka Gejak]

October 21, 2026 at 12:13 PM, "Abdurrahman Karadag" <abdurrahmankaradag19@xxxxxxxxx> wrote:

> Wake only when a ring was recorded as stopped:
> mac80211 keeps a single non-refcounted DRIVER stop per queue, so an
> unconditional wake here would also release the stop that
> rtw_hw_scan_start() takes before it reaches rtw_pci_start() from idle.

The gated wake still releases that stop when a ring was left stopped. A
stalled ring followed by a disconnect keeps queue_stopped set through
rtw_enter_ips(), and the next scan from idle then does:

        rtw_hw_scan_start()
          ieee80211_stop_queues()
          rtw_core_scan_start()
            rtw_leave_ips()
              rtw_core_start()
                rtw_pci_start()
                  ieee80211_wake_queues()

Nothing transmits in idle, so this is harmless, but the v3 thread settled
on saying the wake can't be narrowed to the queue the ring-full path
stopped. Could the message say that, rather than suggest the gate keeps
the scan stop intact?

Other than that I have no objections with the code itself.

Best regards,
Luka Gejak