Re: [PATCH net 06/10] net: pse-pd: do not tie a shared power domain to its creator's devres

From: Carlo Szelinsky

Date: Mon Oct 19 2026 - 15:59:22 EST


On Mon, 19 Oct 2026 08:51:14 +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> [Severity: High]
> Is the shared domain still tied to its creator through this supply handle?

Yes. That is an older bug, and the cover letter lists it as not fixed
here. It needs a supply handle whose consumer device the creator does
not own. I will look at that as a follow-up.

> [Severity: Medium]
> What happens to the PIs handled before the failing one?

Right, this patch alone does not undo them. "net: pse-pd: unwind
allocations when controller registration fails" does: it undoes them
inside pse_register_pw_ds(), while it holds pse_pw_d_mutex. That patch
moves to this series in the next version.

> [Severity: Medium]
> Can the PI regulator ops still run here and see pw_d == NULL?

Yes, in the short window before the PI array is freed. That is the
same older bug as the freed PI array. I will rework the second patch
of [1] and fold it into this series: it stops the PI regulator ops at
the start of unregister, before this flush.

[1] https://lore.kernel.org/netdev/20260813200653.980170-1-github@xxxxxxxxxxxx/

Carlo