Re: [PATCH net 04/10] net: pse-pd: do not reach a freed PHY from the notification worker

[Carlo Szelinsky]

On Mon, 19 Oct 2026 08:51:12 +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> [Severity: Low]
> Could the comment say that it relies on attached_phydev being cleared in
> the shared-PI case?

Yes. I will add that to the comment in the next version.

> [Severity: High]
> This is a pre-existing issue and was not introduced by this patch. This
> patch relies on the pse_control_put() in phy_device_remove(). Does that
> call leave phydev->psec dangling?

Yes, an older bug, and it is not fixed in net. The PSE notifier
series for net-next fixes it: phy_device_remove() clears phydev->psec
under pse_phy_lock(), and the ethtool PSE handlers take the same lock,
so a request that is already running ends before the handle is
dropped.

Carlo