Re: [PATCH v3 7/7] sched/eevdf: Move to a single runqueue

[Vincent Guittot]

On Mon, 19 Oct 2026 at 19:36, Jakub Okoński <jakub@xxxxxxxxxxx> wrote:
>
> Hi Vincent,
>
> Your patch fixes my cpu.idle test case.
>
> On 10/19/26 19:01, Vincent Guittot wrote:
> >  /*
> > - * Preempt the current task with a newly woken task if needed:
> > + * Preempt an idle entity in favor of a non-idle entity (and don't preempt
> > + * in the inverse case).
> > + */
> > +static bool wakeup_preempt_sched_idle(struct sched_entity *cse, struct sched_entity *pse)
>
> This should return enum preempt_wakeup_action. But with that change, on

Argh! Yes I moved from a binary to a ternary value but forgot to
update the prototype

> top of 7.3.0, it still regresses from 7.2.9 if you test with a nice 19
> spinner in the same cgroup. I think it's incomplete.

This patch only aims to fix the sched_idle task group case. I will
have a closer look at the nice 19 case. Have you checked the different
cgroup_mode with nice 19 ?

Vincent