Re: [PATCH v6 10/18] fs/resctrl: Add support for hidden resource group files

[Reinette Chatre]

Hi Babu,

On 10/16/26 1:53 PM, Moger, Babu wrote:
> On 10/15/2026 10:27 AM, Reinette Chatre wrote:
>> On 10/1/26 8:10 AM, Babu Moger wrote:
>>> Some per-group resctrl files are only meaningful once a resource group
>>> has an active kernel mode association.
>>
>> Could this elaborate more about how the files depend on the kernel mode
>> and why they may not always be meaningful?
>>
>>>
>>> Creating them only at activation would complicate group setup and
>>
>> Why would it complicate group setup and teardown? I think it would
>> rather complicate mode activation and de-activation but since there is
>> no detail about how this will complicate group setup it is difficult to
>> compare. It is difficult to reason about a patch when the motivation is
>> vague.
>>
>>> teardown, while exposing them on every group would show empty files
>>
>> "show empty files" - technically these files, as they are implemented,
>> will not be empty but return errors
>>
>>> with no clear purpose.
>>>
>>> Add a hidden property to struct rftype to hide files at creation.
>>
>> Missing a "why".
>> This can append to describe how this adds the foundational support in
>> preparation for features to restore visibility when the feature's files
>> need to be exposed to user space.
>>
> 
> Will rephrase the whole changelog:
> 
> "Some per-group resctrl files are only applicable to resource groups
> with an active kernel mode association. Accessing these files before a
> kernel mode association is established would result in errors and does
> not provide useful information.

What does "and does not provide useful information" refer to? Does this
mean that the errors are not useful?

> 
> Creating and removing these files when a kernel mode is activated or
> deactivated would add complexity to the mode management path. Add a
> hidden property to struct rftype so files can be created with the
> resource group and exposed only when they become applicable.

Please separate the problem and solution descriptions.

> 
> This provides the infrastructure needed to control file visibility for
> future kernel-mode-specific resctrl interfaces."
Reinette