Re: [RFC PATCH 7/8] KEYS: Reject @datalen values over INT_MAX

[David Howells]

Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote:

> -	int delta = (int)datalen - key->datalen;
> +	int delta;
>  	int ret = 0;
>  
>  	key_check(key);
>  
> +	if (datalen > INT_MAX)
> +		return -EINVAL;
> +
> +	delta = (int)datalen - key->datalen;
> +

You don't actually need to move the subtraction.

But apart from that:

Signed-off-by: David Howells <dhowells@xxxxxxxxxx>