Re: [PATCH net-next] net: ti: icssm-prueth: use dev_close()/dev_open() in icssm_prueth_change_mode()

[Saivarun Mudepally]

Hi,
 
> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
> 
> - How the issue was discovered, e.g. hit in production, hit during
>   development, syzbot report, manual code inspection, LLM or static
>   analysis tool scan.
> 

Sashiko, the netdev AI review bot, reported it as a preexisting issue,
while reviewing our ICSSM HSR/PRP offload series
(https://lore.kernel.org/all/179151741150.434549.7819199497598747618@xxxxxxxxxx).

> - Whether the issue was actually triggered, or is only theoretical
>   (e.g. found by code inspection). If it was triggered please include
>   the symptoms, like the stack trace or error messages.
> 

We first confirmed the issue by manual code review. We were also able to
replicate it on TI AM57xx IDK hardware board.

> - What hardware the change was tested on. For driver fixes please
>   mention the device (and if relevant firmware version) used for
>   testing, or say that the change was not tested on real hardware.
> 

We tested the fix on TI AM335x ICE / AM437x IDK / AM57xx IDK with the ICSS-M
PRUETH while changing the protocol from dual-EMAC to RSTP switch mode.


Thanks and Regards,
Sai Varun M.