Re: [PATCH v2] KVM: arm64: Only enable S1PIE and S1POE with the features they imply

[Fuad Tabba]

Hi Marc,

On Mon, 19 Oct 2026 08:31:18 +0100, Marc Zyngier <maz@xxxxxxxxxx> wrote:
[...]
> > I'll send your patch as v3, rebased on -rc3 with you as the author,
>
> Please at least add yourself as a co-author.

Will do, thanks.

> > once I've tested it. I'm dropping v2's trap table changes, since
> > they're redundant once the ID registers are sanitised. I made two
> > changes to your patch. The sanitisation now runs before
> > kvm_init_nv_sysregs(), so the nested RESx masks are computed from the
> > sanitised values.
>
> Isn't that already the case? At least with kvmarm-7.4,
> kvm_vm_finalize_sys_regs() is called before kvm_init_nv_sysregs().

It is. -rc3 doesn't have Mark's split of kvm_finalize_sys_regs(), so
kvm_init_nv_sysregs() still runs there first. I'll rebase v3 on
kvmarm-7.4 and keep the call where you had it.

> > I dropped the res1 half, which isn't set by anything.
>
> I'd like to keep this, as it will eventually get used, just like the
> recompute loop is a bit useless for now, but will become useful in the
> future as dependencies get recomputed.

Ack.

Cheers,
/fuad