Re: [PATCH v2 0/4] iio: light: tsl2591: fix lux calculation and precision, add I2C ID table, report saturation

From: Andy Shevchenko

Date: Mon Oct 19 2026 - 04:53:17 EST


On Mon, Oct 19, 2026 at 10:17:08AM +0200, Jan Remes wrote:
> On Sat, 17 Oct 2026 03:14:11 +0100, Jonathan Cameron wrote:
> > On Thu, 15 Oct 2026 21:36:35 +0300
> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> >
> > > From my view (haven't checked the calculations, though) this looks good,
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> > >
> > I'm guessing not huge urgency on patch 1, so to keep things simple I've
> > applied the lot to the testing branch of iio.git. That will get rebased
> > on rc1 once available in a couple of weeks.
> >
> > If you want the fix to go in faster, shout and I'll do that at risk
> > of slowing down the rest.
> >
> FWIW, I don't think it to be very urgent, as people probably don't use
> it on x86-64 (seeing both as it had only DT probe support and that
> impacted users are likely to have noticed the oops).

What do you mean by the second part of the sentence? It's as easy to use on
ACPI platforms as on DT, we have so nice trick called PRP0001, which allows to
enumerate "OF-only" drivers on ACPI platforms via SSDT overlays (or other means
of DSDT/SSDT provisioning).

> And on Arm, the net result is getting false illumination reading of 0.0,
> which isn't great, but isn't terrible either.

--
With Best Regards,
Andy Shevchenko