[PATCH 0/3] ASoC: tas2783-sdw: volume and firmware load fixes
From: Matthew Schwartz
Date: Sun Oct 18 2026 - 16:00:53 EST
Three tas2783-sdw fixes found while bringing up the ASUS ROG Xbox Ally
X20 [1], whose two TAS2783 amps share a SoundWire link that is powered
off when idle. They don't depend on that series and apply on their own,
but they were tested on the X20 with it applied.
Patch 1 keeps the Amp Volume and Speaker Volume settings in the driver.
The register cache is dropped on every reset, so the controls fail with
-EBUSY while the amp is runtime suspended, and on a link that powers off
when idle a setting is lost on the next wake. It supersedes Lee Mann's
patch for the volume lost across system suspend [2].
Patch 2 loads the firmware synchronously instead of waiting up to three
seconds for an asynchronous callback, which could leave an amp with its
firmware but without its SDCA init writes, or run after an unbind.
Patch 3 then refuses playback, in hw_params and in the port prepare of
a resumed stream, when those init writes failed.
On the X20 the firmware download takes about 1.2 s per amp from cold
and 0.2 s per amp on a wake, when the program RAM is not downloaded
again.
[1] https://lore.kernel.org/r/20261016232416.2628603-1-matthew.schwartz@xxxxxxxxx
[2] https://lore.kernel.org/r/20261016102846.22908-1-leepaulmann@xxxxxxxxx
Matthew Schwartz (3):
ASoC: tas2783-sdw: keep the volume settings across resets
ASoC: tas2783-sdw: load the firmware synchronously
ASoC: tas2783-sdw: refuse playback when the init writes failed
sound/soc/codecs/tas2783-sdw.c | 253 ++++++++++++++++++++++++---------
1 file changed, 188 insertions(+), 65 deletions(-)
base-commit: 2450a9bcd3423612f614ea15ff44966fed189191
--
2.56.0