Re: [PATCH] platform/x86: asus-nb-wmi: map ScreenPad and Task Swap keys

[Victor]

On 10/18/26 20:02, Denis Benato wrote:
> The driver is handling the screenpad so why not implementing the
> functionality in the driver instead of doing the dance driver -> evdev
> -> remap -> driver ?
>
> Unless I misunderstood what you want to do... Hopefully not!

Hi Denis,

Thanks for looking at this.

Handling it in the driver would work, but the key would then only be an
on/off switch for the ScreenPad. If I remember correctly, on Windows the
same key cycled between modes: on, off, and using the ScreenPad as a
touchpad. If the driver toggles the power on every press, userspace
cannot do that, because the panel is already switched off before it
sees the key.

Reporting the key as KEY_F13 allows both. Users who only want on/off can
bind it to the asus_screenpad backlight device, so the power control
still goes through the driver, and others can use it to switch modes.

It also matches hid-asus, which already reports the same ScreenPad code
0x6a as KEY_F13.

While testing this I also found that the ScreenPad power control looks
inverted on this model (UX482EG, stock asus-wmi on 7.2.5). Writing 0
(power on) to /sys/class/backlight/asus_screenpad/bl_power switches the
panel off, about three seconds later its DRM connector reports
disconnected, and writing 4 (power off) brings it back. The result was
the same each time I tried. While the panel is off, actual_brightness
still reads 89, so the firmware seems to report it as powered. I can
look into that separately if it is useful.

> > + { KE_KEY, 0x9C, { KEY_F14 } }, /* Task Swap key on Zenbook Duo */
>
> Fair.

Thanks.

Best regards,
Victor


Den sön 18 okt. 2026 kl 20:02 skrev Denis Benato <denis.benato@xxxxxxxxx>:
>
>
> On 10/17/26 20:13, Victor Gillholm via B4 Relay wrote:
> > From: Victor Gillholm <victor.gillholm@xxxxxxxxx>
> >
> > The ASUS Zenbook Duo 14 UX482EG has two keys next to the power button:
> > one toggles the ScreenPad Plus, the second screen above the keyboard,
> > and one swaps windows between the two screens (Task Swap in ASUS'
> > ScreenXpert software). They emit ASUS WMI event codes 0x6a and 0x9c.
> > Neither code is in the asus-nb-wmi sparse keymap, so pressing them only
> > logs "Unknown key code 0x6a" or "Unknown key code 0x9c", and both keys
> > are reported as KEY_UNKNOWN, so ordinary desktop key bindings cannot
> > tell them apart.
> >
> > Map 0x6a to KEY_F13, the same keycode hid-asus already uses for the
> > ScreenPad toggle code 0x6a. No existing keycode describes moving windows
> > between screens, so map 0x9c to KEY_F14, following the existing use of
> > KEY_F13 and KEY_F14 for other ASUS-specific keys in this keymap. Both
> > keys then emit distinct, bindable events.
> >
> > Tested on an ASUS Zenbook Duo 14 UX482EG: with this change the keys
> > arrive in userspace as KEY_F13 and KEY_F14 and the "Unknown key code"
> > messages are gone.
> >
> > Assisted-by: Claude:claude-opus-5-5
> > Signed-off-by: Victor Gillholm <victor.gillholm@xxxxxxxxx>
> > ---
> > Tested by building asus-nb-wmi against 7.2.5 and loading it in place of
> > the stock module. The key mapping was checked with wev: before the change
> > both keys arrived as keycode 248 with no keysym, after it as XF86Tools
> > (KEY_F13) and XF86Launch5 (KEY_F14).
> > ---
> >  drivers/platform/x86/asus-nb-wmi.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> > index 3b0f3346d..c6eb525ec 100644
> > --- a/drivers/platform/x86/asus-nb-wmi.c
> > +++ b/drivers/platform/x86/asus-nb-wmi.c
> > @@ -641,6 +641,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> >       { KE_KEY, 0x65, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV */
> >       { KE_KEY, 0x66, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV */
> >       { KE_KEY, 0x67, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV */
> > +     { KE_KEY, 0x6A, { KEY_F13 } }, /* ScreenPad toggle on Zenbook Duo */
>
> Hi Victor,
>
> The driver is handling the screenpad so why not implementing the functionality in
> the driver instead of doing the dance driver -> evdev -> remap -> driver ?
>
> Unless I misunderstood what you want to do... Hopefully not!
>
> >       { KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } },
> >       { KE_IGNORE, 0x6E, },  /* Low Battery notification */
> >       { KE_KEY, 0x71, { KEY_F13 } }, /* General-purpose button */
> > @@ -666,6 +667,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> >       { KE_KEY, 0x93, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV + DVI */
> >       { KE_KEY, 0x95, { KEY_MEDIA } },
> >       { KE_KEY, 0x99, { KEY_PHONE } }, /* Conflicts with fan mode switch */
> > +     { KE_KEY, 0x9C, { KEY_F14 } }, /* Task Swap key on Zenbook Duo */
>
> Fair.
>
> Best regards,
> Denis Benato
>
> >       { KE_KEY, 0X9D, { KEY_FN_F } },
> >       { KE_KEY, 0xA0, { KEY_SWITCHVIDEOMODE } }, /* SDSP HDMI only */
> >       { KE_KEY, 0xA1, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + HDMI */
> >
> > ---
> > base-commit: ea40f1e9f07aab937b9a217633be7a1f66260394
> > change-id: 20261017-zenbook-duo-keys-7e0b3f94354a
> >
> > Best regards,
> > --
> > Victor Gillholm <victor.gillholm@xxxxxxxxx>
> >
> >