Re: [PATCH] iio: common: cros_ec_sensors: use sensor_scale union member for CALIBSCALE

From: Jonathan Cameron

Date: Sun Oct 18 2026 - 14:12:05 EST


On Sun, 18 Oct 2026 07:05:12 +0000
Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:

> On Sun, Oct 18, 2026 at 12:02:06AM +0100, Jonathan Cameron wrote:
> > On Tue, 13 Oct 2026 22:55:27 +0300
> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> >
> > > On Tue, Oct 13, 2026 at 02:47:30AM +0530, Arnav Kapoor wrote:
> > > > On Sun, 11 Oct 2026 19:16:41 +0200, Joshua Crofts wrote:
> > > > > Please add a Fixes tag. Otherwise looks good to me!
> > > > >
> > > > > Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> > > >
> > > > Thanks for the review. The mismatch was introduced when CALIBSCALE
> > > > support was added:
> > > >
> > > > Fixes: ed1f2e85da79 ("iio: cros_ec: Add calibscale for 3d MEMS")
> > > >
> > > > Jonathan, could you pick this up when applying, or would you prefer a v2?
> > >
> > > No need to resend, `b4` will scan the whole email thread for the tags.
> > If it could put them in the right order for 'late' fixes tags it would
> > be perfect (easy fix though so don't resend!)
> > >
> >
> > This driver tends to be well maintained so whilst I'm fine
> > with the change I'll wait a bit for a tag from one of the maintainers.
>
> Sorry for the delay, I somehow missed this in my inbox.
>
> Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
Thanks!

Applied to the fixes-togreg branch of iio.git.
I considered taking this one the slow path given it 'works' today
but given we are very early in the cycle seems nicer to just get
it cleaned up.

I dropped the Assisted-by LLM bit given guidance on that has
changed again since this was sent.

Jonathan