Re: [PATCH v3 0/7] HID: asus: ASUS Zenbook Duo keyboard support

[Denis Benato]

On 10/14/26 15:21, Paolo Pisati wrote:
> On Tue, Oct 13, 2026 at 04:56:39PM +0300, Denis Benato wrote:
>> My greatest concern is with report size: every device needs its own and
>> hardcoding it is not an option anymore because no device can be fully
>> made happy (and working): xg mobile is 300, ally and new ROGs is 64,
>> some have 32, some 16 and I think TP is 15.
>>
>> I have yet to look at the patch that changes the report size but please
>> make the report size variable reading it from the descriptor.
> Isn't 5/7 what you are looking for?
>
> asus_kbd_set_report() looks up the feature report with the ID in
> buf[0] and never sends more than hid_report_len() of it, that is what
> the descriptor declares, report ID included. The Zenbook Duo declares
> 15 data bytes for report 0x5a, so the 64 byte backlight buffer goes
> out as 16 bytes, like the handshake, and the keyboard answers it.
> A device declaring 64 or more sees no change.
>
> No hurry, enjoy the vacation.
I just hadn't watched the patch yet. Now I did and yes: you are right
and if that works across devices it's a great thing for this driver as a
whole!

Thank you!