Re: [PATCH] staging: most: dim2: remove redundant dev_err() calls
From: Dan Carpenter
Date: Sun Oct 18 2026 - 07:06:34 EST
On Sun, Oct 18, 2026 at 02:00:50PM +0300, Melih Emik wrote:
> On Sun, Oct 18, 2026 at 01:45:27PM +0300, Dan Carpenter wrote:
> > Don't put this kind of meta commentary in the commit message. It's
> > expected that people test their patches, so there is no need to say
> > it. If there is something unexpected then put it below the ---
> > cut off line
>
> Hi Dan,
>
> Thank you very much for the helpful guidance and explanation! That makes
> complete sense, and I really appreciate you taking the time to point it out.
>
> I have updated the patch to drop the meta commentary from the commit message
> and placed the test notes below the "---" cut-off line in v2.
>
> Thanks again for your review and time!
Please don't send AI emails... It's so depressing and cliche to hear,
"Yes, you are right!" from an AI.
regards,
dan carpenter