Re: [PATCH] staging: most: dim2: remove redundant dev_err() calls

[Dan Carpenter]

On Sun, Oct 18, 2026 at 01:42:23PM +0300, Melih Emik wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() and
> devm_request_irq() automatically log detailed failure diagnostics
> including device name, IRQ number, handlers, and the error code via
> dev_err_probe().
> 
> Consequently, driver-specific dev_err() calls immediately following
> these requests produce duplicate error messages on failure and are
> redundant. Remove the redundant dev_err() calls in dim2_probe().
> 
> Tested:
> - Compiled with W=1 on x86_64 with zero warnings.
> - Verified with lockdep and debug mutexes enabled
>   (CONFIG_PROVE_LOCKING=y, CONFIG_DEBUG_MUTEXES=y).
> - Boot-tested full bzImage in QEMU with initcall_debug, confirming
>   successful driver registration (dim2_driver_init returned 0) and
>   zero lockdep/kernel warnings.
> - Verified with scripts/checkpatch.pl (0 errors, 0 warnings).

Don't put this kind of meta commentary in the commit message.  It's
expected that people test their patches, so there is no need to say
it.  If there is something unexpected then put it below the ---
cut off line

> 
> Signed-off-by: Melih Emik <melihemik@xxxxxxxxxxx>
> ---
  ^^^
here.

regards,
dan carpenter