Re: [PATCH] ALSA: hda/via: Apply runtime PM workaround for ASUS X55A

[Vasiliy Kovalev]

Hi,

On 10/18/26 11:33, Takashi Iwai wrote:
> On Sat, 17 Oct 2026 12:12:57 +0200,
> Vasiliy Kovalev wrote:
> > ASUS X55A requires the same workaround like other machines with
> > VT1802, otherwise it loses the codec power on a few nodes and the
> > sound stays silent.
> >
> > Fixes: a0645daf1610 ("ALSA: HDA: Early Forbid of runtime PM")
> > Link: https://bugzilla.altlinux.org/45606
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > Tested-by: Nikita Maksimov <nickstogramm@xxxxxxxxx>
> > Signed-off-by: Vasiliy Kovalev <kovalev@xxxxxxxxxxxx>
>
> The addition of a quirk is OK, but is Fixes tag really pointing to the
> culprit?  The commit is for forbidding the runtime PM, and I see no
> clear reason how this commit breaks.

I followed the precedent of your B23E patch[1], which carried the
same Fixes tag. If you don't think it applies here, happy to drop
it - let me know if you'd rather remove it yourself or have me
send a v2 without it (keeping Cc: stable).

[1] https://lore.kernel.org/all/20210817052432.14751-1-tiwai@xxxxxxx/

> thanks,
>
> Takashi
>
> > ---
> >   sound/hda/codecs/via.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/hda/codecs/via.c b/sound/hda/codecs/via.c
> > index 807312cffd35..0641fc14b346 100644
> > --- a/sound/hda/codecs/via.c
> > +++ b/sound/hda/codecs/via.c
> > @@ -933,6 +933,7 @@ static const struct hda_fixup via_fixups[] = {
> >   static const struct hda_quirk vt2002p_fixups[] = {
> >   	SND_PCI_QUIRK(0x1043, 0x13f7, "Asus B23E", VIA_FIXUP_POWER_SAVE),
> >   	SND_PCI_QUIRK(0x1043, 0x1487, "Asus G75", VIA_FIXUP_ASUS_G75),
> > +	SND_PCI_QUIRK(0x1043, 0x1c33, "Asus X55A", VIA_FIXUP_POWER_SAVE),
> >   	SND_PCI_QUIRK(0x1043, 0x8532, "Asus X202E", VIA_FIXUP_INTMIC_BOOST),
> >   	SND_PCI_QUIRK_VENDOR(0x1558, "Clevo", VIA_FIXUP_POWER_SAVE),
> >   	{}
> > --
> > 2.50.1

--
Thanks,
Vasiliy