Re: [PATCH v3 0/2] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW

[Marc Zyngier]

On Wed, 14 Oct 2026 13:35:37 +0100,
Julian Braha <julianbraha@xxxxxxxxx> wrote:
> 
> ARM_GIC_V3 currently selects HAVE_ARM_SMCCC_DISCOVERY without ensuring its
> dependency, ARM_PSCI_FW, is met.
> 
> Patch 1 of this series makes the select conditional on arm64, and patch 2
> adds stubs for arm32.
> 
> ---
> Julian Braha (2):
>   irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW
>   firmware: smccc: provide stubs when discovery is disabled
> 
>  drivers/irqchip/Kconfig   | 2 +-
>  include/linux/arm-smccc.h | 7 +++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)

This hasn't been correctly tested, I'm afraid.

The patches are in the wrong order, as applying patch #1 on its own
will break a 32bit ARM build without PSCI (HAVE_ARM_SMCCC_DISCOVERY
not selected, but the stubs that are supposed to save the day are in
patch #2...):

arm-linux-gnueabihf-ld: drivers/irqchip/irq-gic-v3.o: in function `gic_enable_quirk_nvidia_t241':
/home/maz/hot-poop/arm-platforms/drivers/irqchip/irq-gic-v3.c:1816:(.text+0xb04): undefined reference to `arm_smccc_get_soc_id_version'
make[2]: *** [scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1
make[1]: *** [/home/maz/hot-poop/arm-platforms/Makefile:1387: vmlinux] Error 2
make: *** [Makefile:248: __sub-make] Error 2

With the patch ordering fixed and the whole thing applied to the same
tree:

Reviewed-by: Marc Zyngier <maz@xxxxxxxxxx>

	M.

-- 
Without deviation from the norm, progress is not possible.