Re: [net-next,PATCH 2/2] enetc: Make eMDIO MDC rate configurable from DT

[Marek Vasut]

On 10/16/26 10:59 PM, Andrew Lunn wrote:
> > +	div = ((clk_get_rate(enet_clk) / mdc_freq) - 1) / 4;
> > +	if (div < 5 || div > 0x1ff)
> > +		return dev_err_probe(dev, -EINVAL,
> > +				     "Requested MDC frequency is out of range, ignoring\n");
>
> Returning -EINVAL is not really 'ignoring' the invalid value. Since
> these are optional properties which are present, if they are not valid
> returning an error is good. So please fix the message.

All right, done in V2, thanks !

> Why is dev < 5 an issue?
The clock would be way too fast, on MX95 that would be over 33 MHz.