Re: [PATCH v7 3/7] EDAC/amd64: Stop matching Hygon CPUs

[Yazen Ghannam]

On Fri, Oct 09, 2026 at 05:01:07PM +0800, Lin Wang wrote:
> amd64_edac gets its node count and DF devices from the AMD northbridge
> cache. Since commit 49b96fc0dddc ("x86/amd_nb: Simplify function 3
> search"), the cache finds function 3 only at the fixed PCI slots
> 0x18 + N. Hygon DF devices are not at those slots, so the cache is
> discarded on Hygon and amd64_edac_init() returns -ENODEV at its
> amd_nb_num() check.
> 
> Remove the Hygon match and the empty Family 0x18 case. MCE decoding
> in mce_amd.c is separate and unchanged. Hygon memory controller support
> will use the Hygon node interfaces in a separate series.
> 
> Signed-off-by: Lin Wang <wanglin@xxxxxxxxxxxxxx>
> ---
>  drivers/edac/amd64_edac.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 475235c402e8..9e35098d3dd2 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3840,9 +3840,6 @@ static int per_family_init(struct amd64_pvt *pvt)
>  		}
>  		break;
>  
> -	case 0x18:
> -		break;
> -
>  	case 0x19:
>  		switch (pvt->model) {
>  		case 0x00 ... 0x0f:
> @@ -4120,7 +4117,6 @@ static const struct x86_cpu_id amd64_cpuids[] = {
>  	X86_MATCH_VENDOR_FAM(AMD,	0x15, NULL),
>  	X86_MATCH_VENDOR_FAM(AMD,	0x16, NULL),
>  	X86_MATCH_VENDOR_FAM(AMD,	0x17, NULL),
> -	X86_MATCH_VENDOR_FAM(HYGON,	0x18, NULL),
>  	X86_MATCH_VENDOR_FAM(AMD,	0x19, NULL),
>  	X86_MATCH_VENDOR_FAM(AMD,	0x1A, NULL),
>  	{ }
> -- 

Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>

Thanks,
Yazen