Re: [PATCH v2] riscv: mm: Trace TLB flush path selection

From: Roman Storozhenko

Date: Sat Oct 17 2026 - 09:55:50 EST


On Fri, Oct 16, 2026 at 4:36 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Sun, 30 Aug 2026 16:36:37 +0200
> Roman 'Hedin' Storozhenko <romeusmeister@xxxxxxxxx> wrote:
>
> > diff --git a/include/trace/events/riscv_tlb.h b/include/trace/events/riscv_tlb.h
>
> Please do not put architecture specific events in include/trace.
>
> They belong in the architecture.
>
> See the example code in samples/trace_events/trace-events-sample.[ch]
> as well as the Makefile there on how to put trace events in directories
> outside of include/trace/
>
> Thanks,
>
> -- Steve
>

Hi Steve,

Thanks for the review.

I've moved the trace event definition to
arch/riscv/include/asm/riscv_tlb.h in v5, following the existing
RISC-V tracepoint convention.

The updated patch is available here:
https://lore.kernel.org/linux-riscv/20261017-tlb_tracepoint-v5-1-256fb5393a7f@xxxxxxxxx/

Thanks for pointing this out.

--
Kind regards,
Roman 'Hedin' Storozhenko