RE: [PATCH v15 10/11] clk: realtek: Add RTD1625-ISO clock controller driver

[Yu-Chun Lin [林祐君]]

Hi Jerome,

> > +static RTK_CLK_REGMAP_GATE(clk_en_usb_p4, "clk_sys", 0, 0x8c, 0, 0);
> > +static RTK_CLK_REGMAP_GATE(clk_en_usb_p3, "clk_sys", 0, 0x8c, 1, 0);
> > +static RTK_CLK_REGMAP_GATE(clk_en_misc_cec0, "clk_en_misc", 0, 0x8c,
> > +2, 0); static RTK_CLK_REGMAP_GATE(clk_en_cbusrx_sys, "clk_sys", 0,
> > +0x8c, 3, 0); static RTK_CLK_REGMAP_GATE(clk_en_cbustx_sys, "clk_sys",
> > +0, 0x8c, 4, 0); static RTK_CLK_REGMAP_GATE(clk_en_cbus_sys,
> > +"clk_sys", 0, 0x8c, 5, 0); static
> > +RTK_CLK_REGMAP_GATE(clk_en_cbus_osc, "osc27m", 0, 0x8c, 6, 0);
> 
> You are requesting your input by global here. This is wrong.
> DT names are stable, internal CCF are not. You should not rely on this.
> 
> Either give it a name in your bindings and use fw_name or use index
> 
> Same applies to the other controller
> 

Agreed.

We will add a 'clock-names' property in the dt-bindings for external input clocks.

And will use 'RTK_CLK_REGMAP_GATE_FW_NAME()', which uses
'CLK_HW_INIT_FW_NAME()' to set '.fw_name' for these external input clocks.

Best Regards,
Yu-Chun

> --
> Jerome