Re: [PATCH net-next v11 3/6] net: pcs: xpcs: add Rockchip RK3568 platform glue driver

[Coia Prant]

Jakub Kicinski <kuba@xxxxxxxxxx> 于2026年10月17日周六 07:37写道：
>
> On Fri,  9 Oct 2026 01:51:57 +0800 Coia Prant wrote:
> > +config PCS_XPCS_PLATFORM
> > +     tristate "Generic XPCS controller support"
> > +     default PCS_XPCS
>
> Why the default? Surely there are platforms with PCS_XPCS enabled
> which work today == don't care about the new code?
>
> Linus is known to hate _any_ new symbols defaulting to enabled
> on olddefconfig.
>
> > +     help
> > +       Generic DWXPCS driver for platforms that don't require any
> > +       platform specific code to function or is using platform
> > +       data for setup.
> > +
> > +       If you have a controller with this interface, say Y or M here.
> > +
> > +config PCS_XPCS_ROCKCHIP
> > +     tristate "Rockchip XPCS controller support"
> > +     default ARCH_ROCKCHIP
>
> Same here.
>

Thanks, both defaults are dropped in v12:

- PCS_XPCS_PLATFORM no longer defaults to PCS_XPCS. There is no
  in-tree user of the generic snps,dw-xpcs glue that needs it selected
  by default, so platforms that need it select it explicitly.

- PCS_XPCS_ROCKCHIP no longer defaults to ARCH_ROCKCHIP. DWMAC_ROCKCHIP
  already selects it.

Link: https://lore.kernel.org/all/20261017054406.1828061-1-coiaprant@xxxxxxxxx/T/#t

- Coia