Re: [PATCH v2 30/53] rtc: m48t35: support the SGI IP35 timekeeper's 1968 year base

[Imre Kaloz]

Hello Alexandre,

On Tue, 13 Oct 2026, Alexandre Belloni wrote:

<snip>

> Instead of open coding, you should use start_secs after setting the rtc
> range in probe(). attached i a patch I refreshed for the
> devm_rtc_allocate_device/devm_rtc_register_device conversion that you
> can include in this series. drivers/rtc/rtc-mt6397.c is an example that
> should be working for you.
>
> I never sent the patch because it is not clear from the datasheet how
> well leap year calculation works. My guess is that it worked in 2000 but
> fails in 2100.

Thanks, that is cleaner. In the next posting I'll take your devm
conversion first and set range_min/range_max and start_secs in probe
instead of open-coding the epoch.


Thanks,
Imre