Re: [PATCH net-next v3] tg3: normalize inherited BCM5718 register byte order
From: Sebastian Andrzej Siewior
Date: Fri Oct 16 2026 - 17:39:12 EST
On 2026-10-11 21:41:58 [+0200], Magnus Lindholm wrote:
> Firmware can leave BCM5718 vendor registers byte-swapped while standard
> PCI fields retain normal byte order. Detect this from the host-control
> revision marker, byte-swap bit and swapped product ID, without matching
> a platform model or PCI subsystem. Prefer the normal revision marker
> so already-normal controllers do not enter the normalization path.
…
>
> Limit detection to BCM5718, whose register layout and inherited state
> were checked on M3000 hardware. Other controller families retain their
> existing initialization path.
This boils down to firmware sets BYTE_SWAP and we need get it out in
order to have the device working and break anything while at it.
I have here DEVICE_TIGON3_5720 on x86. I forced that byte in, had the
register swapped and then it fixed it back.
> Signed-off-by: Magnus Lindholm <linmag7@xxxxxxxxx>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Sebastian