Re: [PATCH net-next v3 4/6] net: ftgmac100: Require phy-mode for AST2700

From: Andrew Lunn

Date: Fri Oct 16 2026 - 17:02:45 EST


On Thu, Oct 15, 2026 at 02:46:56PM +0800, Jacky Chou wrote:
> The driver currently defaults to RGMII when the "phy-mode" property
> is missing from the device tree. This default is no longer valid for
> AST2700, which also supports RMII via FTGMAC100_QUIRK_RMII_ENABLE.
>
> Make "phy-mode" a required property for AST2700 and fail probe with
> an error message if it is not specified, instead of silently
> defaulting to RGMII.
>
> Signed-off-by: Jacky Chou <jacky_chou@xxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew