Re: [PATCH net-next v6 7/9] net: dsa: realtek: rtl8365mb: add family D SDS13 PCS support

[Linus Walleij]

On Fri, Oct 16, 2026 at 3:07 AM Mieczyslaw Nalewaj <namiltd@xxxxxxxxx> wrote:

> Extend the existing RTL8367S SGMII/HSGMII PCS implementation in this
> driver for family D switches, whose CPU SerDes is reached through the
> indexed SDS13 window and whose SDS_MISC fields differ from family C.

We can't assume everyone knows acronyms like this.

PCS = Physical Coding Sublayer, something needed for SerDes.

I don't know much about SerDes and I know even less about
gritty details like that so we need to spell it out for fools like me.

> The register sequence and tuning tables are derived from the GPL-licensed
> Realtek RTL8367D port API distributed in the Mercusys MR80X GPL release.
> Keep the existing family C path unchanged and select the new behavior from
> the driver's chip-family metadata, making the implementation reusable by
> other family D boards.
>
> This patch only prepares the family D paths; they become reachable
> when the RTL8367S-VB chip entry is added in the last patch.
>
> Co-developed-by: Fabiano Tassotti <fabianotassotti@xxxxxxxxx>
> Signed-off-by: Fabiano Tassotti <fabianotassotti@xxxxxxxxx>
> Signed-off-by: Mieczyslaw Nalewaj <namiltd@xxxxxxxxx>

WIth the requested clarifications:
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij