Re: [PATCH] watchdog: allow WATCHDOG_PRETIMEOUT_GOV_SEL=y

[Guenter Roeck]

On 10/4/26 14:37, Dmitry Voytik wrote:
> Fix the issue when WATCHDOG_PRETIMEOUT_GOV_SEL can't be set to =y,
> and always is =m.
>
> The issues can be reproduced with the following steps:
> 	make mrproper
> 	make defconfig
> 	./scripts/config \
> 	  -e WATCHDOG_CORE \
> 	  -e WATCHDOG_PRETIMEOUT_GOV \
> 	  -e WATCHDOG_PRETIMEOUT_GOV_SEL \
> 	  --refresh
> 	make olddefconfig
> 	make mod2yesconfig
>
> 	grep '=m$' .config
> returns only CONFIG_WATCHDOG_PRETIMEOUT_GOV_SEL as module:
> 	CONFIG_WATCHDOG_PRETIMEOUT_GOV_SEL=m
>
> "make menuconfig" doesn't let it to be switched from =m to =y either.

This does not explain what the problem actually is that is supposed
to be solved with this patch. Since this is just a selector used to
enable other configurations, and the configuration option does not
result in any packages built, "WATCHDOG_PRETIMEOUT_GOV_SEL can't be
set to =y" on its own is not a problem.

Guenter

> Signed-off-by: Dmitry Voytik <voytikd@xxxxxxxxx>
> ---
>   drivers/watchdog/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index f7d0a0c2c0ef..712ebfa1c99c 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -92,7 +92,7 @@ config WATCHDOG_PRETIMEOUT_GOV
>   config WATCHDOG_PRETIMEOUT_GOV_SEL
>   	tristate
>   	depends on WATCHDOG_PRETIMEOUT_GOV
> -	default m
> +	default WATCHDOG_CORE
>   	select WATCHDOG_PRETIMEOUT_GOV_PANIC if \
>   		WATCHDOG_PRETIMEOUT_GOV_NOOP=n && WATCHDOG_PRETIMEOUT_GOV_DUMP=n
>