Re: [PATCH 1/2] tty: serial: remove hub6 multiport support

From: Arnd Bergmann

Date: Fri Oct 16 2026 - 11:33:35 EST


On Fri, Oct 16, 2026, at 15:28, Andy Shevchenko wrote:
> On Fri, Oct 16, 2026 at 02:59:47PM +0200, Arnd Bergmann wrote:
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> But there are some minor issues to fix, see below.
>
> ...
>
>> {
>> unsigned long old_iobase, old_mapbase;
>> - unsigned int old_type, old_iotype, old_hub6, old_shift;
>> + unsigned int old_type, old_iotype, old_shift;
>
> Move it line up, so we will have reversed xmas tree order.
>
> ...
>
>> + /* hub6 is no longer support */
>> + if (new_info->hub6 != 0)
>> + return -EINVAL;
>
> Please, fix the indentation, should use tabs.

Fixed both, and the typo in the comment here, thanks
for the review!

Arnd