Re: [PATCH 1/2] dt-bindings: iio: light: Add AMS TCS3472 and TCS3400

[Krzysztof Kozlowski]

On 16/10/2026 10:15, HuskerMinion via B4 Relay wrote:
> From: HuskerMinion <mocker-mug-unwoven@xxxxxxxx>
> 
> The tcs3472 driver has no binding yet. It matches DT nodes only through
> its I2C device ID.
> 
> Document the TCS3472 family and the AMS TCS3400 family, which the next
> patch adds to the driver. Both are I2C color sensors with one threshold
> interrupt and a VDD supply.
> 
> Signed-off-by: HuskerMinion <mocker-mug-unwoven@xxxxxxxx>

Please read submitting patches how to properly attribute the work with
your real and known identity


> ---
>  .../devicetree/bindings/iio/light/ams,tcs3472.yaml | 57 ++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/ams,tcs3472.yaml b/Documentation/devicetree/bindings/iio/light/ams,tcs3472.yaml
> new file mode 100644
> index 000000000..cd4a0516e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/ams,tcs3472.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/ams,tcs3472.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMS TCS3472 and TCS3400 color light-to-digital converters
> +
> +maintainers:
> +  - HuskerMinion <mocker-mug-unwoven@xxxxxxxx>
> +
> +description: |
> +  Color light sensors with 16-bit clear, red, green and blue channels, an
> +  I2C interface and a threshold interrupt.
> +
> +  The TCS3472 family covers the TCS34721, TCS34723, TCS34725 and TCS34727.
> +  The TCS3400 family covers the TCS34001, TCS34003, TCS34005 and TCS34007.

We do not take families, but actual devices. TCS3400 seems to be a real
device, so I don't get why you call it a family.


> +  The variants differ in I2C address and interface voltage.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ams,tcs3400
> +      - ams,tcs3472

Your driver cod suggests these are compatible, so it should be expressed.


Best regards,
Krzysztof