Re: [PATCH 14/38] arm: dts: qcom: apq8064: Align multiple property data

[Waqar Hameed]

On Mon, Oct 12, 2026 at 17:52 +0200 Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:

> On 10/2/26 12:36 AM, Waqar Hameed wrote:
>> Multiple property data on a newline should be aligned with the first one
>> or properly indented with tabs. Found/fixed with dtfmt (Devicetree
>> Source formatter).
>>
>> Signed-off-by: Waqar Hameed <waqar.hameed@xxxxxxxx>
>> ---
>>  arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 98 ++++++++++++------------
>>  1 file changed, 49 insertions(+), 49 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
>> index 150b5670e13b3..565f98c00b3fb 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
>> +++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
>> @@ -89,7 +89,7 @@ l2: l2-cache {
>>               idle-states {
>>                       cpu_spc: cpu-spc {
>>                               compatible = "qcom,idle-state-spc",
>> -                                             "arm,idle-state";
>> +                                          "arm,idle-state";
>>                               entry-latency-us = <400>;
>>                               exit-latency-us = <900>;
>>                               min-residency-us = <3000>;
>> @@ -1036,15 +1036,15 @@ gpu: gpu@4300000 {
>>                       interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
>>                       interrupt-names = "kgsl_3d0_irq";
>>                       clock-names =
>> -                         "core",
>> -                         "iface",
>> -                         "mem",
>> -                         "mem_iface";
>> +                             "core",
>
> As before, let's add a rule to prohibit `property =\n`

Let's see what the discussions on patch 22 result in. It could maybe be
applied here as well, e.g.

	clock-names = "corecorecorecorecorecorecorecorecorecorecorecorecorecorecore";

would be wrapped to

	clock-names =
    	"corecorecorecorecorecorecorecorecorecorecorecorecorecorecore";

To fit 100 chars. Then multiple property string data would follow the
same logic:

	clock-names =
		"corecorecorecorecorecorecorecorecorecorecorecorecorecorecore",
		"iface",
		"mem",
		"mem_iface";

Which maybe is more clean than allowing the first string to overflow 100
chars and aligning others to that one:

	clock-names = "corecorecorecorecorecorecorecorecorecorecorecorecorecorecore",
		      "iface",
		      "mem",
		      "mem_iface";

So the question is if we should either "try to fit within 100 chars, by
adding newline after `=`" or "don't care about property data longer that
100 chars, always start first one after `=` on the same line". The
latter one is of course much easier to implement :)