Re: [PATCH 00/10] HID: hid-lenovo-go-s: Fix various bugs

[Derek J. Clark]

On October 16, 2026 3:03:06 AM PDT, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
>On Mon, 14 Sep 2026, Derek J. Clark wrote:
>
>> This series fixes various bugs in the hid-lenovo-go-s driver
>> 
>> Patch 1 fixes a dropped error on return from mcu_property_out()
>> 
>> Patch 2 creates a mechanism to ignore stale responses if they timed out
>> in the previous command.
>> 
>> Patch 3 fixes a deadlock if the device is removed while cfg_setup() is
>> running.
>> 
>> Patch 4 adds missing pm_ptr to the reset_resume function pointer.
>> 
>> Patch 5 adds a kobject_uevent notify during reset-resume to ensure the
>> os_mode return is caught by udev.
>> 
>> Patch 6 adds a suspend callback to cancel delayed work and re-queue the
>> cfg_setup if the device was suspended prior to or during the work.
>> 
>> Patch 7 moves attribute init to the end of cfg_setup, ensuring the
>> attributes can only be used once the MCU is ready.
>> 
>> Patch 8 reorganizes hid_gos_cfg and renamed it to gos_cfg_drvdata in
>> preparation for later fixes.
>> 
>> Patch 9 moves the static led_classdev to become a member of the drvdata
>> struct.
>> 
>> Patch 10 moved drvdata from a static global to a device allocated
>> struct.
>
>Given where we currently are in the development process, I've queued the 
>whole lot in hid.git#for-7.4/lenovo, thanks.

Hi Jiri,

I've fixed the bugs Sashiko pointed out locally yesterday (a few of them were quite valid) and have been waiting for my local sashiko pass to submit v2. I'd recommend waiting to merge them if possible. I should be able to submit them today.

Thanks,
Derek