Re: [PATCH 10/38] arm: dts: qcom: apq8060: Indent property data with tab

[Waqar Hameed]

On Mon, Oct 12, 2026 at 17:24 +0200 Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:

> On 10/2/26 12:36 AM, Waqar Hameed wrote:
>> Multiple property data on a newline should be indented with tabs.
>> Found/fixed with dtfmt (Devicetree Source formatter).
>> 
>> Signed-off-by: Waqar Hameed <waqar.hameed@xxxxxxxx>
>> ---
>>  .../dts/qcom/qcom-apq8060-dragonboard.dts     | 28 +++++++++----------
>>  1 file changed, 14 insertions(+), 14 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts
>> index 4dc63032cccb6..6ede4e5af4494 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts
>> +++ b/arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts
>> @@ -966,25 +966,25 @@ dragon_ebi2_pins: ebi2-state {
>>  		 */
>>  		mux0-pins {
>>  			pins =
>> -			    /* "gpio39", CS1A_N this is not good to mux */
>
> Here I see a possibility for improvement - we shouldn't really be
> breaking lines at the assignment operator

Yeah, this should be discussed and decided. dtfmt is pragmatic right now
and follows the existing style it encounters. That is, if there is a
newline after the assignment (like here), it respects it and follows
that. Try removing the newline after `=` here and run dtfmt again. It
will then align ...

>> -			    "gpio40", /* CS2A_N */
>> -			    "gpio134"; /* CS0_N testpoint TP29 */
>> +				/* "gpio39", CS1A_N this is not good to mux */
>> +				"gpio40", /* CS2A_N */
>> +				"gpio134"; /* CS0_N testpoint TP29 */
>>  			function = "ebi2cs";
>>  		};

... these lines accordingly.

[...]