Re: [PATCH 19/38] arm: dts: qcom: ipq4019: Break long property array data

[Waqar Hameed]

On Mon, Oct 12, 2026 at 17:26 +0200 Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:

> On 10/2/26 12:36 AM, Waqar Hameed wrote:
>> There is an awkward line break at the last elements expression. Put all
>> elements on a newline instead. Found/fixed with dtfmt (Devicetree Source
>> formatter).
>> 
>> Signed-off-by: Waqar Hameed <waqar.hameed@xxxxxxxx>
>> ---
>>  arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
>> index 1fa1aef140a12..51721fedf7d60 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
>> +++ b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
>> @@ -135,8 +135,9 @@ memory {
>>  
>>  	pmu {
>>  		compatible = "arm,cortex-a7-pmu";
>> -		interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) |
>> -					 IRQ_TYPE_LEVEL_HIGH)>;
>> +		interrupts = <
>> +			GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)
>> +		>;
>
> I find this equally awkward.. especially since this fits below
> 100 chars

Yeah, I agree. dtfmt tries to be pragmatic and guess the intended style
of where to have the opening `<` and closing `>` of the array (since
there is no definitive answer in the kernel). That is, if the `<` and
`>` are different lines, then you probably want to keep that (many
examples of this in devictree files in the kernel tree).

I will remove the newline. If you now run dtfmt after that, it properly
formats it on one line (since `<` and `>` are on the same line now).

One of the hardest things left to implement is line wrapping (i.e. lines
spanning over 100 chars). Which has been left out due to too many
uncertainties. I'll be happy is we could come to some kind of agreement
on how to do that (but I'll guess that will take some time indeed...).