Re: [PATCH v5 6/9] ASoC: dt-bindings: qcom: Add Hawi LPASS macro codecs

From: Krzysztof Kozlowski

Date: Fri Oct 16 2026 - 09:58:09 EST


On 16/10/2026 10:14, Prasad Kumpatla wrote:
>
> On 10/15/2026 3:08 PM, Krzysztof Kozlowski wrote:
>> Are you sure you are not using source clock names?
>
> On Hawi this RX input is sourced from the LPR vote (LPASS_HW_LPR_VOTE)

That the source clock name. Look, where LPASS_HW_LPR_VOTE is used:

> instead of the MACRO vote used on sm8550:
>
> clocks = <&q6prmcc LPASS_CLK_ID_RX_CORE_TX_MCLK ...>,
> <&q6prmcc*LPASS_HW_LPR_VOTE* ...>,

Here. LPASS_HW_LPR_VOTE is the name in q6prmcc.

> <&q6prmcc LPASS_HW_DCODEC_VOTE ...>,
> <&lpass_vamacro>;
> clock-names = "mclk",*"lpr"*, "dcodec", "fsgen";
>
> "lpr" is the same style of name as the existing "macro"/"dcodec" entries,

That's the same vote as here, no? Vote for main block (macro)?

> not a parent/source name. An sm8550 fallback can't be used here because it
> pins input #2 to "macro", which no longer matches the LPR source on Hawi;
> the other three inputs are unchanged, so RX gets its own clock-names.
>
> Thanks,
> Prasad
>


Best regards,
Krzysztof