Re: [PATCH 0/9] HID: Hardening report validation and unnumbered report handling

[bentiss]

> This series improves validation and consistency across HID core,
> transport drivers, and individual device drivers for numbered and
> unnumbered reports.
> 
> Bluetooth HIDP and HID core report retrieval handling are updated to
> properly respect the kernel convention where raw report request buffers
> reserve the first byte for the report ID, using 0 for unnumbered
> reports.
> 
> Report descriptors mixing numbered and unnumbered reports within the
> same report enumeration are rejected in accordance with the HID
> specification.
> 
> Report ID verification for successful report retrieval transfers is
> centralized in the HID core, with a new device quirk to accommodate
> buggy firmware (such as the ASUS ROG Flow Z13 touchpad). Redundant
> report ID checks are removed across the I2C-HID, Goodix SPI, Intel
> QuickI2C, multitouch, and PlayStation drivers.
> 

Hi Dmitry,

I'm fine with the series. Sashiko has valid concerns on all patches it
replied to except the first one, which is a pre-existing issue.

Could you fix the uhid case (by making the internal API similar to what
you did in hidp), and address the other Sashiko remarks?

Cheers,
Benjamin

-- 
Benjamin Tissoires <bentiss@xxxxxxxxxx>