Re: [PATCH v4] arm64: dts: qcom: sm7125-samsung: add initial device tree

[Konrad Dybcio]

On 10/13/26 3:58 PM, Erikas Bitovtas wrote:
> Samsung Galaxy A52/A72 are devices released on atoll (SM7125) platform
> in 2021. Add initial device tree for SM7125 Samsung platform with

[...]

> +&soc {
> +	i2c_17: i2c-17 {

This is not a MMIO device, so it doesn't belong under /soc

Have you tried using the bus through the normal QUP driver path?

> +		compatible = "i2c-gpio";
> +		sda-gpios = <&tlmm 51 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
> +		scl-gpios = <&tlmm 52 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;

style nit: (foo | bar) instead of (foor|bar), please


[...]


> +&usb_1 {
> +	qcom,select-utmi-as-pipe-clk;

Is there no superspeed / DP altmode?

Konrad