Re: [PATCH RFC 2/4] phy: qcom-mipi-csi2: Add C-PHY support for X1E80100

From: Bryan O'Donoghue

Date: Fri Oct 16 2026 - 06:12:48 EST


On 16/10/2026 11:06, George Neacsu wrote:
Hi Bryan,

Thanks for the reviews, and thanks to Loic as well.

The series is on next-20261015. There, phy-qcom-mipi-csi2-3ph-dphy.c is
blob 966d79c98, the same as on the media-committers next branch
Series doesn't apply to linux-next or phy-next - given we are at -rc7 linux-next is probably better, after -rc7 phy-next is best.

Either -next:

[~/Development/worktree/bod-media-committers]$ git fetch linux-next *[bod-qcom-media-committers]
[~/Development/worktree/bod-media-committers]$ git reset --hard linux-next/master *[bod-qcom-media-committers]
HEAD is now at b810335a0699d Add linux-next specific files for 20261015
[~/Development/worktree/bod-media-committers]$ b4 shazam 20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@xxxxxxxxx *[bod-qcom-media-committers]
Looking up https://lore.kernel.org/all/20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@xxxxxxxxx/
Grabbing thread from lore.kernel.org/all/20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@xxxxxxxxx/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 15 messages in the thread
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
✗ [PATCH RFC 1/4] phy: Add MIPI C-PHY mode and configuration options
+ Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> (✓ DKIM/linaro.org)
✗ [PATCH RFC 2/4] phy: qcom-mipi-csi2: Add C-PHY support for X1E80100
✗ [PATCH RFC 3/4] media: qcom: camss: csid-680: Select C-PHY in the receiver
+ Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx> (✓ DKIM/oss.qualcomm.com)
✗ [PATCH RFC 4/4] media: qcom: camss: Configure C-PHY through the PHY API
---
✗ No key: ed25519/geocausa@xxxxxxxxx
---
Total patches: 4
---
Applying: phy: Add MIPI C-PHY mode and configuration options
Applying: phy: qcom-mipi-csi2: Add C-PHY support for X1E80100
Applying: media: qcom: camss: csid-680: Select C-PHY in the receiver
Applying: media: qcom: camss: Configure C-PHY through the PHY API
Patch failed at 0004 media: qcom: camss: Configure C-PHY through the PHY API
error: patch failed: drivers/media/platform/qcom/camss/camss-csiphy.c:329
error: drivers/media/platform/qcom/camss/camss-csiphy.c: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Or -phy:

[~/Development/worktree/bod-media-committers]$ git fetch phy *[bod-qcom-media-committers]
From git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy
c7f2322431cb6..8f56fdf3d8cb9 next -> phy/next
[~/Development/worktree/bod-media-committers]$ git reset --hard phy/next *[bod-qcom-media-committers]
Updating files: 100% (16814/16814), done.
HEAD is now at 8f56fdf3d8cb9 phy: tegra: Add support for Tegra238 XUSB pad controller
[~/Development/worktree/bod-media-committers]$ git am --abort *[bod-qcom-media-committers]
warning: You seem to have moved HEAD since the last 'am' failure.
Not rewinding to ORIG_HEAD
[~/Development/worktree/bod-media-committers]$ b4 shazam 20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@xxxxxxxxx *[bod-qcom-media-committers]
Looking up https://lore.kernel.org/all/20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@xxxxxxxxx/
Grabbing thread from lore.kernel.org/all/20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@xxxxxxxxx/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 15 messages in the thread
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
✗ [PATCH RFC 1/4] phy: Add MIPI C-PHY mode and configuration options
+ Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> (✓ DKIM/linaro.org)
✗ [PATCH RFC 2/4] phy: qcom-mipi-csi2: Add C-PHY support for X1E80100
✗ [PATCH RFC 3/4] media: qcom: camss: csid-680: Select C-PHY in the receiver
+ Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx> (✓ DKIM/oss.qualcomm.com)
✗ [PATCH RFC 4/4] media: qcom: camss: Configure C-PHY through the PHY API
---
✗ No key: ed25519/geocausa@xxxxxxxxx
---
Total patches: 4
---
Applying: phy: Add MIPI C-PHY mode and configuration options
Applying: phy: qcom-mipi-csi2: Add C-PHY support for X1E80100
Applying: media: qcom: camss: csid-680: Select C-PHY in the receiver
Applying: media: qcom: camss: Configure C-PHY through the PHY API
Patch failed at 0004 media: qcom: camss: Configure C-PHY through the PHY API
error: patch failed: drivers/media/platform/qcom/camss/camss-csiphy.c:329
error: drivers/media/platform/qcom/camss/camss-csiphy.c: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"