Re: [PATCH v2 0/3] HID: asus: improve the driver support for laptops
From: Jiri Kosina
Date: Fri Oct 16 2026 - 05:49:35 EST
On Fri, 9 Oct 2026, Denis Benato wrote:
> Hi all,
>
> Antheas has requested reviewing the XG mobile patch on this cycle so
> I am re-submotting a modified version that is a bit cleaner because
> it uses LED_CORE_SUSPENDRESUME instead of re-sending the LED state
> manually on resume, but it's functionally equivalent.
>
> I also included a patch to fix a pre-existing issue that was flagged
> by sashiko-bot, albeit I'm not entirely sure if it can really happen
> in practice, though it is safer to handle it correctly given the
> actual code change is so small and leaving it documented helps future
> changes.
>
> I also moved some code to reduce nesting and improve the resume path
> on ROG ally and other N-KEY devices.
>
> Best regards,
> Denis Benato
>
> Link v1: https://lore.kernel.org/all/20260813144736.2477941-1-denis.benato@xxxxxxxxx/
>
> Changelog:
>
> -v2
> - HID: asus: add support for xgm led
> - Solve an impossible error reported by sashiko-bot regarding teardown on error
Applied to hid.git#for-7.4/asus, thanks.
--
Jiri Kosina
SUSE Labs