Re: [PATCH v6 1/6] dt-bindings: iio: imu: icm42600: Add ICM-42670-P

[Kanak Shilledar]

Hi,
> > > 
[...]
> > > That's misleading or confusing. Either the device works or does
> > > not
> > > without interrupt hooked up. Consult hardware datasheet if in
> > > doubts.
> > > 
> > > Driver support is different thing here and you cannot make it
> > > required
> > > later, because that would be unjustified ABI break.
> > 
> > I looked into icm42605 data sheet and saw no clear statement about
> > the interrupts
> > being required. The timing diagrams only show protocol specific
> > lines and it
> > looks like the interrupt sources can even be disabled (not routed
> > out to any
> > interrupt pin). Maybe I'm missing something and the interrupts are
> > required for
> > some sort of reset function or so? Otherwise, I don't see how the
> > interrupts are
> > required.
> > 
> > Kanak, do you have access to any of those other chips to test
> > whether they work
> > without interrupts? If possible, can you also check the data sheets
> > for the other
> > parts besides icm42370p and icm42605?
> > 
> > Maybe
> >  - if:
> >      properties:
> >        compatible:
> >          contains:
> >            enum:
> >              - invensense,icm42600
> >              - invensense,icm42602
> >              - invensense,icm42605
> >              - invensense,icm42622
> >              - invensense,icm42631
> >              - invensense,icm42686
> >              - invensense,icm42688
> >    then:
> >      required:
> >        - interrupts
> > was a documentation mistake?
> > 
> > With best regards,
> > Marcelo
> > 
> > 
> 
> Hello,
> 
> I can confirm that all icm426xx chips can work without interrupt by
> just polling
> the data.
> 
> Interrupts were declared as required at the time only because the
> driver doesn't
> work without interrupt (probe will fails).
> 
> Hardware speaking only, this is indeed a documentation mistake.

Thank you for confirming the requirement for interrupts. I will cleanup
the documentation in a separate commit not part of this series and the
driver should be updated to not fail if the interrupt property is
absent in the devicetree.

Best Regards,
Kanak Shilledar

Attachment: signature.asc
Description: This is a digitally signed message part