Re: [PATCH 1/2] dt-bindings: gpio: gpio-davinci: Add the tda54 support

[Aniket Limaye]

Hi Bartosz,


On 28/09/26 17:58, Bartosz Golaszewski wrote:
> On Wed, 23 Sep 2026 14:56:44 +0200, Aniket Limaye <a-limaye@xxxxxx> said:
> > New version of GPIO IP used in TDA54 SoCs adds support for level-triggered
> > interrupts via extended registers.
> > Add the device binding for ti,tda54-gpio.
>
> Nit: Does the new feature really matter for the binding if it doesn't warrant
> any changes in properties?
>
> Bart

I have sent v2 with no changes, sorry I missed this comment.
https://lore.kernel.org/all/20261016-upstream-tda54-gpio-v2-0-5c4f8b10cdbc@xxxxxx/

How would you like me to add the extended registers/level-triggered 
interrupts in dt-bindings? The compatible doesn't really need any new 
properties, but does tell the driver that extended register sets for 
level-triggered interrupts are supported by the IP.

Thanks,
Aniket

> > Signed-off-by: Aniket Limaye <a-limaye@xxxxxx>
> > ---
> >   Documentation/devicetree/bindings/gpio/gpio-davinci.yaml | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> > index 1434d08f8b74..02b6b9a436a6 100644
> > --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> > @@ -18,6 +18,7 @@ properties:
> >                 - ti,am654-gpio
> >                 - ti,j721e-gpio
> >                 - ti,am64-gpio
> > +              - ti,tda54-gpio
> >             - const: ti,keystone-gpio
> >
> >         - items:
> >
> > --
> > 2.53.0