Re: [PATCH] staging: greybus: Remove unused function 'to_fw_mgmt_connection'

[Jeremy Clifton]

On 10/13/26 2:12 PM, Alex Elder wrote:
> On 10/13/26 1:17 PM, Jeremy Dean Clifton wrote:
> > Remove unused function from greybus driver to_fw_mgmt_connection.
> >
> > This function is not exported or called from anywhere tree-wide.
> >
> > Confirmed with git grep and cscope.
> >
> > Signed-off-by: Jeremy Dean Clifton <deaner92@xxxxxxxxx>
>
> Looks good to me.  Are there other unused functions
> like this?
I did not find any others like this one. There may be some in rtl. I 
think that is going away soon, though.

> Reviewed-by: Alex Elder <elder@xxxxxxxxxxxx>
Thank you
> > ---
> >   drivers/staging/greybus/fw-core.c | 7 -------
> >   1 file changed, 7 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/ 
> > greybus/fw-core.c
> > index 78321be80013..46b35ef55090 100644
> > --- a/drivers/staging/greybus/fw-core.c
> > +++ b/drivers/staging/greybus/fw-core.c
> > @@ -21,13 +21,6 @@ struct gb_fw_core {
> >   static struct spilib_ops *spilib_ops;
> > -struct gb_connection *to_fw_mgmt_connection(struct device *dev)
> > -{
> > -    struct gb_fw_core *fw_core = dev_get_drvdata(dev);
> > -
> > -    return fw_core->mgmt_connection;
> > -}
> > -
> >   static int gb_fw_spi_connection_init(struct gb_connection *connection)
> >   {
> >       int ret;